Deprecation below 7.2.5 #2707
Deprecation below 7.2.5 #2707
Conversation
composer.json
Outdated
| "php": ">=7.2.5", | ||
| "guzzlehttp/guzzle": "^7.4.5", | ||
| "guzzlehttp/psr7": "^2.4.5", | ||
| "guzzlehttp/promises": "^2.0", |
There was a problem hiding this comment.
we don't need to drop 1.x here. we can have ^1.5.3 || ^2.0.
composer.json
Outdated
| "guzzlehttp/promises": "^1.4.0", | ||
| "php": ">=7.2.5", | ||
| "guzzlehttp/guzzle": "^7.4.5", | ||
| "guzzlehttp/psr7": "^2.4.5", |
There was a problem hiding this comment.
we don't need to drop 1.x here. we can have ^1.9.1 || ^2.4.5. having extra return types in your implementations is still compatible with v1.
src/S3/ObjectCopier.php
Outdated
| @@ -79,7 +79,7 @@ public function __construct( | |||
| * | |||
| * @return Coroutine | |||
| */ | |||
| public function promise() | |||
| public function promise(): \GuzzleHttp\Promise\PromiseInterface | |||
There was a problem hiding this comment.
can we add a use statement and shorten the return type?
src/Waiter.php
Outdated
| @@ -89,7 +89,7 @@ public function __construct( | |||
| /** | |||
| * @return Coroutine | |||
| */ | |||
| public function promise() | |||
| public function promise(): \GuzzleHttp\Promise\PromiseInterface | |||
There was a problem hiding this comment.
Same thing here- could we shorten this return type?
| @@ -32,8 +32,8 @@ | |||
| $autoloaderContents = [ | |||
| 'Aws/functions.php', | |||
| 'GuzzleHttp/functions_include.php', | |||
| 'GuzzleHttp/Psr7/functions_include.php', | |||
| 'GuzzleHttp/Promise/functions_include.php', | |||
| 'GuzzleHttp/Psr7/Utils.php', | |||
There was a problem hiding this comment.
It is not necessary to include these two utils files.
There was a problem hiding this comment.
Happy to revert this if you wanted to give the PR another once-over.
There was a problem hiding this comment.
It's not a bug, just unnecessary to include these classes explicitly, since they already get autoloaded like the others. The original code was only necessary to include functions - functions cannot (currently) be autoloaded.
There was a problem hiding this comment.
We'll keep that in mind and will probably add something to our backlog for this. If you notice anything else, definitely let us know.
This reverts commit 84d4539.
Co-authored-by: Sean O'Brien <[email protected]>
This pull request is a work in progress and will be added to over time. This will be merged before the release on Tuesday, August 15th, 2023 and will be a minor version bump that ends support for php versions below 7.2.5.